[PM-8938] two factor settings authenticator validation

ike-kottlowski commented 3 months ago

🎟️ Tracking

📔 Objective

Validation on token field and error toasts were failing silently when users try to add improper token values. This communicates user friendly validation information to the end user.

📸 Screenshots

https://github.com/bitwarden/clients/assets/137194738/a0902cdf-22b0-4fde-b3b4-c6cf34ca5ca4

https://github.com/bitwarden/clients/assets/137194738/18764d31-4603-45c5-9942-55573ef8236a

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 29.46%. Comparing base (c01f6be) to head (2805e9f).

Files	Patch %	Lines
...uth/settings/two-factor-authenticator.component.ts	16.66%	4 Missing and 1 partial :warning:
...src/app/auth/settings/two-factor-base.component.ts	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #9857 +/- ## ======================================= Coverage 29.46% 29.46% ======================================= Files 2537 2537 Lines 74045 74050 +5 Branches 13827 13829 +2 ======================================= + Hits 21814 21821 +7 + Misses 50579 50576 -3 - Partials 1652 1653 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

Checkmarx One – Scan Summary & Details – 0cd88ac1-021d-4dca-94fe-f6a4b8380eee

bitwarden / clients