bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.06k stars 1.2k forks source link

[PM-9344] Clarify accepted user state #9861

Closed MGibson1 closed 3 months ago

MGibson1 commented 3 months ago

๐ŸŽŸ๏ธ Tracking

User feedback of lost vaults due to thinking that Emergency Access was completed.

https://bitwarden.atlassian.net/browse/PM-9344

๐Ÿ“” Objective

Prefer Needs confirmation to Accepted display status. This emphasizes that action is still required to complete setup.

๐Ÿ“ธ Screenshots

image image

โฐ Reminders before review

๐Ÿฆฎ Reviewer guidelines

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.57%. Comparing base (b7a961b) to head (c2d9f17). Report is 24 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9861 +/- ## ========================================== + Coverage 29.52% 29.57% +0.05% ========================================== Files 2538 2538 Lines 74137 74166 +29 Branches 13850 13855 +5 ========================================== + Hits 21886 21932 +46 + Misses 50591 50575 -16 + Partials 1660 1659 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

Logo Checkmarx One โ€“ Scan Summary & Details โ€“ c331dbb7-ed7b-4a17-8686-ce7d9445038b

No New Or Fixed Issues Found

JaredSnider-Bitwarden commented 3 months ago

@MGibson1 , I noticed that there are no more usages of "accepted" anywhere in the web app. Should we remove the translation as well or that is unnecessary?