bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
8.66k stars 1.14k forks source link

PM-8545 Defect Upload License Dialog should close after file upload #9871

Open KiruthigaManivannan opened 5 days ago

KiruthigaManivannan commented 5 days ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-8545

📔 Objective

Upload License Dialog should close after file upload

update-license-dialog.component.ts - Added dialogRef close to submit and close method

📸 Screenshots

Couldn't test in self hosted mode. But code changes are done. Please check

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 29.51%. Comparing base (9820316) to head (98a7d3d).

Files Patch % Lines
.../billing/shared/update-license-dialog.component.ts 16.66% 4 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9871 +/- ## ========================================== - Coverage 29.52% 29.51% -0.01% ========================================== Files 2538 2538 Lines 74137 74143 +6 Branches 13850 13851 +1 ========================================== + Hits 21886 21887 +1 - Misses 50591 50595 +4 - Partials 1660 1661 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 5 days ago

Logo Checkmarx One – Scan Summary & Details9c4fb108-b69f-49dc-9ce1-928733250b18

No New Or Fixed Issues Found