[PM-9048] Remove check preventing account switching on Safari

djsmith85 commented 5 days ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-9048

📔 Objective

We had to previously disable account switching on Safari (https://github.com/bitwarden/clients/pull/7510) due some performance and issue within Sends and switching accounts.

These should be resolved by migrating Sends over to StateProviders and all the MV3 work should have resolved the performance issues back when this was tested.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.52%. Comparing base (3a3ff43) to head (5960ff8).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #9874 +/- ## ======================================= Coverage 29.51% 29.52% ======================================= Files 2538 2538 Lines 74144 74141 -3 Branches 13851 13850 -1 ======================================= + Hits 21887 21893 +6 + Misses 50597 50588 -9 Partials 1660 1660 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 5 days ago

Checkmarx One – Scan Summary & Details – f3ded0b4-a1c9-48ae-8e1f-cbf431619a47

bitwarden / clients