Assign to collections should show up on the admin console.
The fix for this was to move the showBulkMove(which is only set for individual vault to prevent the assign to collection option from showing up in the trash filter) from bulkAssignToCollectionsAllowed function to showAssignToCollections. showAssignToCollections is used by the individual vault to know when to hide or show the menu option.
๐ธ Screenshots
โฐ Reminders before review
Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
๐ฆฎ Reviewer guidelines
๐ (:+1:) or similar for great changes
๐ (:memo:) or โน๏ธ (:information_source:) for notes or general info
โ (:question:) for questions
๐ค (:thinking:) or ๐ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
๐จ (:art:) for suggestions / improvements
โ (:x:) or โ ๏ธ (:warning:) for more significant problems or concerns needing attention
๐ฑ (:seedling:) or โป๏ธ (:recycle:) for future improvements or indications of technical debt
๐๏ธ Tracking
https://bitwarden.atlassian.net/browse/PM-9370
๐ Objective
Assign to collections should show up on the admin console.
The fix for this was to move the
showBulkMove
(which is only set for individual vault to prevent theassign to collection
option from showing up in the trash filter) frombulkAssignToCollectionsAllowed
function toshowAssignToCollections
.showAssignToCollections
is used by the individual vault to know when to hide or show the menu option.๐ธ Screenshots
โฐ Reminders before review
๐ฆฎ Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or โน๏ธ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or ๐ญ (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or โ ๏ธ (:warning:
) for more significant problems or concerns needing attention:seedling:
) or โป๏ธ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes