bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.06k stars 1.2k forks source link

Auth/PM-4950 - Fix hint and verify delete components that had the route data in the wrong place #9877

Closed JaredSnider-Bitwarden closed 3 months ago

JaredSnider-Bitwarden commented 3 months ago

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-4950

๐Ÿ“” Objective

See title.

๐Ÿ“ธ Screenshots

Hint has title:

image

Verify delete has title:

image

โฐ Reminders before review

๐Ÿฆฎ Reviewer guidelines

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.51%. Comparing base (a613d9c) to head (0843ecd). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9877 +/- ## ========================================== - Coverage 29.52% 29.51% -0.01% ========================================== Files 2537 2537 Lines 74143 74143 Branches 13851 13851 ========================================== - Hits 21889 21882 -7 - Misses 50594 50601 +7 Partials 1660 1660 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

Logo Checkmarx One โ€“ Scan Summary & Details โ€“ b2c983b0-f067-4c68-91fc-d9d44cc3a0f8

No New Or Fixed Issues Found