[PM-9365] [PM-9366] Assign to collections throws error

gbubemismith commented 4 days ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-9366 https://bitwarden.atlassian.net/browse/PM-9365

📔 Objective

Refactor from here only sets the selectedOrgId when an organization is selected from the form which causes the error when organization ciphers are selected for assignment.

📸 Screenshots

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 29.27%. Comparing base (4f4039d) to head (08bf684).

Files	Patch %	Lines
...ult/src/components/assign-collections.component.ts	0.00%	8 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## vault/PM-7625 #9879 +/- ## ================================================= - Coverage 29.48% 29.27% -0.22% ================================================= Files 2539 2529 -10 Lines 74335 73966 -369 Branches 13908 13833 -75 ================================================= - Hits 21920 21654 -266 + Misses 50749 50683 -66 + Partials 1666 1629 -37 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 days ago

Checkmarx One – Scan Summary & Details – f49860cf-27be-434d-ab32-54227f2b583b

bitwarden / clients