Remove labeling of PRs with needs-qa

trmartin4 commented 4 days ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-9381

📔 Objective

We currently add a needs-qa label on all PRs that are opened against main.

This was created when we did not have feature flags as an option, and our standard practice was long-lived feature branches for all changes. We wanted to avoid accidentally merging PRs to main without QA, and this label was designed to help with that.

Now, we have a mix of QA on main with flagged changes and QA on feature branches with unflagged changes. This makes the needs-qa label much less helpful, and it loses its meaning when it is increasingly removed as we move to more QA in main.

This PR removes the workflow that automatically adds the label.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.52%. Comparing base (f0673dd) to head (6596983).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #9880 +/- ## ========================================== - Coverage 29.53% 29.52% -0.01% ========================================== Files 2537 2537 Lines 74154 74154 Branches 13855 13855 ========================================== - Hits 21903 21896 -7 - Misses 50592 50599 +7 Partials 1659 1659 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 days ago

Checkmarx One – Scan Summary & Details – 2464e276-6a68-4ead-9ba7-a5ab745b1229

bitwarden / clients