[PM-9318] Fix username on protonpass import

djsmith85 commented 3 months ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-9318

📔 Objective

Protonpass has changed their export format and this broke the import of usernames

Renamed username to itemEmail and added itemUsername

Fix username field used for ProtonPass import - https://github.com/bitwarden/clients/commit/25b948b7dc59bda096189552920a7cc1206b82a9
Import additional field itemUsername - https://github.com/bitwarden/clients/commit/315e511e6b16127c22a6ca3581f93ca89c6c45f3

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.52%. Comparing base (8f66d60) to head (315e511). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #9889 +/- ## ========================================== - Coverage 29.53% 29.52% -0.01% ========================================== Files 2538 2538 Lines 74159 74160 +1 Branches 13855 13855 ========================================== - Hits 21905 21899 -6 - Misses 50594 50601 +7 Partials 1660 1660 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

quexten commented 3 months ago

:question: question: In the future, if Proton does split it up by username and email (auto-detecting this by the field), would it make sense to detect which field is set on the Proton export, and set the bitwarden username to the export itemUsername/itemEmail if just one of the proton export fields is set, and if both are set do bitwarden-username = proton.itemUsername, bitwarden-custom-field-email=proton.itemEmail? (Most of my bitwarden accounts have their email set in the username and it feels be unintuitive to have no username but only a custom email field)

github-actions[bot] commented 3 months ago

Checkmarx One – Scan Summary & Details – 87e89dca-e193-4114-9955-77306ccc3e1e

bitwarden / clients