Closed quexten closed 9 hours ago
Attention: Patch coverage is 0%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 29.53%. Comparing base (
93a57e6
) to head (74c8e15
). Report is 38 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
...top/src/services/native-message-handler.service.ts | 0.00% | 1 Missing :warning: |
...s/desktop/src/services/native-messaging.service.ts | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Checkmarx One â Scan Summary & Details â 80dabfc0-2194-4c27-8384-748d8254aaf4
Severity | Issue | Source File / Package | Checkmarx Insight |
---|---|---|---|
![]() |
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 1256 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
![]() |
Unpinned Actions Full Length Commit SHA | /build-cli.yml: 406 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
![]() |
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 1210 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
Severity | Issue | Source File / Package |
---|---|---|
![]() |
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 1222 |
![]() |
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 1268 |
![]() |
Unpinned Actions Full Length Commit SHA | /build-cli.yml: 402 |
![]() |
Unsafe_Use_Of_Target_blank | /apps/web/src/app/auth/settings/two-factor-authenticator.component.html: 45 |
![]() |
Unsafe_Use_Of_Target_blank | /apps/web/src/app/auth/settings/two-factor-authenticator.component.html: 58 |
đī¸ Tracking
đ Objective
Since
sha1
is not an encryption algorithm, but a cryptographic hash function - used in the rsa-oaep padding scheme before encrypting using the actual encryption algorithm - RSA - for clarity, this renames the variables referencingsha1
fromEncryptionAlgorithm
toHashAlgorithmForAsymmetricEncryption
, making the code slightly easier to follow.đ¸ Screenshots
â° Reminders before review
đĻŽ Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or âšī¸ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or đ (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or â ī¸ (:warning:
) for more significant problems or concerns needing attention:seedling:
) or âģī¸ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes