bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
8.66k stars 1.14k forks source link

Rename "encryptionAlgorithm" to "hashAlgorithmForEncryption" for clarity #9891

Closed quexten closed 9 hours ago

quexten commented 2 days ago

🎟ī¸ Tracking

📔 Objective

Since sha1 is not an encryption algorithm, but a cryptographic hash function - used in the rsa-oaep padding scheme before encrypting using the actual encryption algorithm - RSA - for clarity, this renames the variables referencing sha1 from EncryptionAlgorithm to HashAlgorithmForAsymmetricEncryption, making the code slightly easier to follow.

📸 Screenshots

⏰ Reminders before review

đŸĻŽ Reviewer guidelines

codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 29.53%. Comparing base (93a57e6) to head (74c8e15). Report is 38 commits behind head on main.

Files Patch % Lines
...top/src/services/native-message-handler.service.ts 0.00% 1 Missing :warning:
...s/desktop/src/services/native-messaging.service.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9891 +/- ## ========================================== + Coverage 29.33% 29.53% +0.20% ========================================== Files 2528 2538 +10 Lines 73768 74159 +391 Branches 13772 13855 +83 ========================================== + Hits 21637 21905 +268 - Misses 50509 50594 +85 - Partials 1622 1660 +38 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 days ago

Logo Checkmarx One – Scan Summary & Details – 80dabfc0-2194-4c27-8384-748d8254aaf4

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1256 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 406 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1210 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1222
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1268
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 402
LOW Unsafe_Use_Of_Target_blank /apps/web/src/app/auth/settings/two-factor-authenticator.component.html: 45
LOW Unsafe_Use_Of_Target_blank /apps/web/src/app/auth/settings/two-factor-authenticator.component.html: 58