bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
8.66k stars 1.14k forks source link

[PM-7846] Implement a rust based native messaging proxy and IPC system #9894

Open dani-garcia opened 2 days ago

dani-garcia commented 2 days ago

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-7846

๐Ÿ“” Objective

๐Ÿ“ธ Screenshots

โฐ Reminders before review

๐Ÿฆฎ Reviewer guidelines

codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 29.55%. Comparing base (33c985e) to head (86bb958). Report is 1 commits behind head on main.

Files Patch % Lines
apps/desktop/src/main/native-messaging.main.ts 0.00% 27 Missing :warning:
apps/desktop/src/entry.ts 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9894 +/- ## ========================================== + Coverage 29.52% 29.55% +0.02% ========================================== Files 2538 2535 -3 Lines 74159 74057 -102 Branches 13855 13846 -9 ========================================== - Hits 21898 21890 -8 + Misses 50601 50507 -94 Partials 1660 1660 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 days ago

Logo Checkmarx One โ€“ Scan Summary & Details โ€“ 73f7c8e1-3ba9-45d6-9c8d-0034c84e8eef

Fixed Issues

Severity Issue Source File / Package
LOW Client_Weak_Cryptographic_Hash /apps/desktop/src/proxy/ipc.ts: 24