bitwarden / desktop

The desktop vault (Windows, macOS, & Linux).

https://bitwarden.com

GNU General Public License v3.0

3.54k stars 401 forks source link

Resolve cross-compile for rust #1481

Closed Hinton closed 2 years ago

Hinton commented 2 years ago

Type of change

[x] Bug fix
[ ] New feature development
[ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
[x] Build/deploy pipeline (DevOps)
[ ] Other

Objective

1379 didn't work correctly when cross compiled. This PR adds a custom build script which ensures we build for all platforms we currently support.

The artifacts are filtered using electron-builder which ensures we don't include binaries for other environments.

EC-141

Testing requirements

Ensure the mac build runs correctly on both intel and arm.

Before you submit

[ ] I have checked for linting errors (npm run lint) (required)
[ ] This change requires a documentation update (notify the documentation team)
[ ] This change has particular deployment requirements (notify the DevOps team)

Hinton commented 2 years ago

@mimartin12 I added caching which should save us a couple of minutes while building this.