bitwarden / desktop

The desktop vault (Windows, macOS, & Linux).
https://bitwarden.com
GNU General Public License v3.0
3.54k stars 401 forks source link

[CP-96] Capitalize menu items consistently #1489

Closed dnicolson closed 2 years ago

dnicolson commented 2 years ago

Type of change

Objective

This pull request makes the capitalization consistent for menu items across English dialects and uses word capitalization rules for short prepositions.

The use of "Check for Updates…" in other apps appears to be almost universal and replaces "Check For Updates" (en) and "Check for updates" (en_GB/en_IN).

Before you submit

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

Hinton commented 2 years ago

Hi @dnicolson,

We only modify the english message.json file, the other files are synced using Crowdin per https://github.com/bitwarden/desktop/blob/master/CONTRIBUTING.md#localization-l10n. Please revert everything except en/messages, and I'll get product to take a look at this.

Hinton commented 2 years ago

Thanks for the quick update @dnicolson, looks good.