[EC-156] [BEEEP] Remove factory providers in Angular DI - Githubissues

bitwarden / desktop

The desktop vault (Windows, macOS, & Linux).

https://bitwarden.com

GNU General Public License v3.0

3.54k stars 399 forks source link

[EC-156] [BEEEP] Remove factory providers in Angular DI #1496

Closed eliykat closed 2 years ago

eliykat commented 2 years ago

Type of change

[ ] Bug fix
[ ] New feature development
[x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
[ ] Build/deploy pipeline (DevOps)
[ ] Other

Objective

See https://github.com/bitwarden/jslib/pull/775.

Code changes

update services.module.ts to use the new tokens
extract init logic to an initService so that it's not mixed in with provider logic

Screenshots

Testing requirements

Before you submit

[x] I have checked for linting errors (npm run lint) (required)
[ ] This change requires a documentation update (notify the documentation team)
[ ] This change has particular deployment requirements (notify the DevOps team)