BRE-207 - Remove logic for 'rc' branch - Githubissues

bitwarden / directory-connector

A tool for syncing a directory (AD, LDAP, Azure, G Suite, Okta) to an organization.

https://bitwarden.com

GNU General Public License v3.0

249 stars 84 forks source link

BRE-207 - Remove logic for 'rc' branch #521

Closed vgrassia closed 1 month ago

vgrassia commented 1 month ago

Type of change

[ ] Bug fix
[ ] New feature development
[ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
[X] Build/deploy pipeline (DevOps)
[ ] Other

Objective

This PR removes the logic for the rc branch. This project is developed and released very infrequently so the complicated logic for the rc branch is not needed.

Card

Code changes

.github/workflows/build.yml: Remove rc and hotfix-rc references.
.github/workflows/cleanup-rc-branch.yml: No longer needed.
.github/workflows/release.yml: Changed logic from rc branch to main branch.
.github/workflows/test.yml: Removed rc and hotfix-rc references.
.github/workflows/version-bump.yml: Removed rc branch logic.

Before you submit

[ ] I have checked for linting errors (npm run lint) (required)
[ ] I have added unit tests where it makes sense to do so (encouraged but not required)
[ ] This change requires a documentation update (notify the documentation team)
[ ] This change has particular deployment requirements (notify the DevOps team)

bitwarden-bot commented 1 month ago

Checkmarx One – Scan Summary & Details – 27205006-4725-441a-9848-00d6e02193ef

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Unpinned Actions Full Length Commit SHA	/version-bump.yml: 194	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
	Unpinned Actions Full Length Commit SHA	/version-bump.yml: 47	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
	Unpinned Actions Full Length Commit SHA	/build.yml: 641	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
	Unpinned Actions Full Length Commit SHA	/version-bump.yml: 25	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
	Unpinned Actions Full Length Commit SHA	/version-bump.yml: 119	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
	Unpinned Actions Full Length Commit SHA	/version-bump.yml: 111	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
	Unpinned Actions Full Length Commit SHA	/version-bump.yml: 104	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity	Issue	Source File / Package
	Unpinned Actions Full Length Commit SHA	/version-bump.yml: 29
	Unpinned Actions Full Length Commit SHA	/version-bump.yml: 135
	Unpinned Actions Full Length Commit SHA	/version-bump.yml: 63
	Unpinned Actions Full Length Commit SHA	/cleanup-rc-branch.yml: 21
	Unpinned Actions Full Length Commit SHA	/version-bump.yml: 120
	Unpinned Actions Full Length Commit SHA	/version-bump.yml: 127
	Unpinned Actions Full Length Commit SHA	/version-bump.yml: 210
	Unpinned Actions Full Length Commit SHA	/build.yml: 643