Closed brant-livefront closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 89.07%. Comparing base (
043c1c7
) to head (1615d2e
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Checkmarx One â Scan Summary & Details â dcc50d9f-b764-442e-b7d5-7bbf260dd132
@fedemkr This dismissed your approval because this was re-targeted to main
once I merged the other PR in and I needed to fix some conflicts when this merged in.
đī¸ Tracking
đ Objective
This PR cleans up the DataStore and keys when a user disables sync. When a user disables sync (after turning it on) for an account, we delete all of that account's items from the shared store. We then check to see if this was the last account to have sync turned on. If there are no other accounts with sync turned on, we then delete the main shared Authenticator key from the App Group keychain. If there are more accounts still with sync turned on, we leave the key in place.
This allows a user to turn off sync for one or all of their accounts and we clear everything up so that there's no left over data from having turned sync on.
Note: This PR is based off of the branch for this open PR. The other PR would need to be approved/merged first, or this will merge into that PR and wait for it to be approved/merge.
â° Reminders before review
đĻŽ Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or âšī¸ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or đ (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or â ī¸ (:warning:
) for more significant problems or concerns needing attention:seedling:
) or âģī¸ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes