Closed KatherineInCode closed 4 weeks ago
Checkmarx One โ Scan Summary & Details โ a29157e9-5a23-496f-8bc2-237c90cc6532
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.50%. Comparing base (
450808c
) to head (c067fd7
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
๐๏ธ Tracking
https://bitwarden.atlassian.net/browse/PM-10542
๐ Objective
When a TOTP was removed from a login entry that had one, the app was saving the TOTP as an empty string rather than nil; as well, if asked to generate a code for an empty string, it would assume it a valid key and generate it. This change adjusts this so that empty and whitespace-only strings coalesce into nil values. Some tests around this are also added.
โฐ Reminders before review
๐ฆฎ Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or โน๏ธ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or ๐ญ (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or โ ๏ธ (:warning:
) for more significant problems or concerns needing attention:seedling:
) or โป๏ธ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes