bitwarden / ios

Bitwarden mobile app for iOS.
https://bitwarden.com
GNU General Public License v3.0
199 stars 25 forks source link

[PM-10541] Don't show notice that TOTP codes require premium on login items without TOTP codes #841

Closed KatherineInCode closed 2 months ago

KatherineInCode commented 2 months ago

🎟ī¸ Tracking

https://bitwarden.atlassian.net/browse/PM-10541

📔 Objective

This adjusts the logic for showing the notice that TOTP codes require premium to only appear on login items that have an associated TOTP code.

📸 Screenshots

Simulator Screenshot - iPhone 15 Pro - 2024-08-19 at 13 07 30

⏰ Reminders before review

đŸĻŽ Reviewer guidelines

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.51%. Comparing base (6cba789) to head (63677af). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #841 +/- ## ======================================= Coverage 88.51% 88.51% ======================================= Files 606 606 Lines 30262 30263 +1 ======================================= + Hits 26787 26788 +1 Misses 3475 3475 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 months ago

Logo Checkmarx One – Scan Summary & Details – 56f525df-d80e-4b2f-8686-65cd55fde1ac

No New Or Fixed Issues Found