[PM-10541] Don't show notice that TOTP codes require premium on login items without TOTP codes

KatherineInCode commented 2 months ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10541

📔 Objective

This adjusts the logic for showing the notice that TOTP codes require premium to only appear on login items that have an associated TOTP code.

📸 Screenshots

Simulator Screenshot - iPhone 15 Pro - 2024-08-19 at 13 07 30

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.51%. Comparing base (6cba789) to head (63677af). Report is 3 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #841 +/- ## ======================================= Coverage 88.51% 88.51% ======================================= Files 606 606 Lines 30262 30263 +1 ======================================= + Hits 26787 26788 +1 Misses 3475 3475 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 months ago

Checkmarx One – Scan Summary & Details – 56f525df-d80e-4b2f-8686-65cd55fde1ac

bitwarden / ios