[PM-11189] Allow app to build in Xcode 16

KatherineInCode commented 3 weeks ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11189

📔 Objective

Xcode 15 and 16 have different signatures for UIApplication.beginBackgroundTask(::) due to changes in Swift Concurrency, and that was preventing the app from building in Xocde 16.

This does not fix tests, however—that will have to wait until a new version of ViewInspector to be released. This work is captured in PM-11213.

This is part of the broader effort to get the app ready for iOS 18, Xcode 16, and Swift 6

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

github-actions[bot] commented 3 weeks ago

Checkmarx One – Scan Summary & Details – b705e191-9693-4a7b-aabb-11212d5872c4

No New Or Fixed Issues Found

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 88.49%. Comparing base (76f791e) to head (c37c780). Report is 3 commits behind head on main.

Files	Patch %	Lines
...warden/Application/UIApplication+Application.swift	0.00%	8 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #845 +/- ## ========================================== - Coverage 88.51% 88.49% -0.03% ========================================== Files 606 607 +1 Lines 30267 30275 +8 ========================================== Hits 26792 26792 - Misses 3475 3483 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bitwarden / ios