bitwarden / ios

Bitwarden mobile app for iOS.
https://bitwarden.com
GNU General Public License v3.0
199 stars 25 forks source link

[PM-11133] Eliminate some static variable warnings #850

Closed KatherineInCode closed 2 months ago

KatherineInCode commented 2 months ago

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-11133

๐Ÿ“” Objective

This is part of the iOS 18 / Xcode 16 / Swift 6 effort.

This eliminates errors with static variables, either by turning them from var into let or making the enum Sendable.

โฐ Reminders before review

๐Ÿฆฎ Reviewer guidelines

github-actions[bot] commented 2 months ago

Logo Checkmarx One โ€“ Scan Summary & Details โ€“ b49e6163-9287-4199-8177-3610d94b5147

No New Or Fixed Issues Found

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.50%. Comparing base (ffbd89a) to head (2c03c8a). Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #850 +/- ## ======================================= Coverage 88.50% 88.50% ======================================= Files 609 609 Lines 30303 30303 ======================================= Hits 26820 26820 Misses 3483 3483 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.