bitwarden / ios

Bitwarden mobile app for iOS.
https://bitwarden.com
GNU General Public License v3.0
199 stars 25 forks source link

PM-11152: Handle key connector migration for existing user #854

Closed matt-livefront closed 2 months ago

matt-livefront commented 2 months ago

๐ŸŽŸ๏ธ Tracking

PM-11152

๐Ÿ“” Objective

If key connector is enabled for an organization or a user is added to an organization that uses key connector, the user's account needs to be migrated to using a key connector key. As part of this migration, the user's master password is removed.

๐Ÿ“ธ Screenshots

https://github.com/user-attachments/assets/3876b15c-bcb4-4ddc-9fc1-5e4b34ff068f

โฐ Reminders before review

๐Ÿฆฎ Reviewer guidelines

github-actions[bot] commented 2 months ago

Logo Checkmarx One โ€“ Scan Summary & Details โ€“ bbcaea2b-b038-450e-bc9d-6d0d714dc5df

No New Or Fixed Issues Found

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 98.42520% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.61%. Comparing base (1352e32) to head (e9d1d02). Report is 4 commits behind head on main.

Files Patch % Lines
...emoveMasterPassword/RemoveMasterPasswordView.swift 90.90% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #854 +/- ## ========================================== + Coverage 88.56% 88.61% +0.05% ========================================== Files 611 613 +2 Lines 30361 30524 +163 ========================================== + Hits 26888 27049 +161 - Misses 3473 3475 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.