Closed KatherineInCode closed 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.56%. Comparing base (
2ed93f0
) to head (5d4c776
). Report is 4 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Checkmarx One – Scan Summary & Details – 4d221d55-e111-43dc-8e88-169aac1e97b6
@fedemkr I'm really not sure, and I found that very strange as well. My googling for it didn't find anything useful on the subject, though.
Thinking about it, it probably makes sense to just close this, and handle each of them on a case-by-case basis to be honest (especially with the next commit I'm putting together, where I'm having to add even more of them)
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11133
📔 Objective
This is part of the iOS 18 / Xcode 16 / Swift 6 effort
This adds
@preconcurrency
annotations to import statements to reduce warnings for now. In the future, we will want to remove these once the imported libraries have been updated; that work is captured also in PM-11195, though as@preconcurrency
annotations become unnecessary they will turn into warnings.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or ⚠️ (:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes