bitwarden / ios

Bitwarden mobile app for iOS.
https://bitwarden.com
GNU General Public License v3.0
140 stars 12 forks source link

[PM-11133] Add preconcurrency annotations to imports #855

Closed KatherineInCode closed 3 weeks ago

KatherineInCode commented 3 weeks ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11133

📔 Objective

This is part of the iOS 18 / Xcode 16 / Swift 6 effort

This adds @preconcurrency annotations to import statements to reduce warnings for now. In the future, we will want to remove these once the imported libraries have been updated; that work is captured also in PM-11195, though as @preconcurrency annotations become unnecessary they will turn into warnings.

⏰ Reminders before review

🦮 Reviewer guidelines

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.56%. Comparing base (2ed93f0) to head (5d4c776). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #855 +/- ## ======================================= Coverage 88.56% 88.56% ======================================= Files 611 611 Lines 30361 30361 ======================================= Hits 26888 26888 Misses 3473 3473 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 weeks ago

Logo Checkmarx One – Scan Summary & Details4d221d55-e111-43dc-8e88-169aac1e97b6

No New Or Fixed Issues Found

KatherineInCode commented 3 weeks ago

@fedemkr I'm really not sure, and I found that very strange as well. My googling for it didn't find anything useful on the subject, though.

Thinking about it, it probably makes sense to just close this, and handle each of them on a case-by-case basis to be honest (especially with the next commit I'm putting together, where I'm having to add even more of them)