[PM-11133] Annotate things as Sendable

KatherineInCode commented 3 weeks ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11133

📔 Objective

This is part of the iOS 18 / Xcode 16 / Swift 6 effort

This adds Sendable annotations to various struct and enum declarations that were not already implicitly Sendable. This greatly reduces the number of warnings with strict concurrency turned on. As well, @preconcurrency annotations are being added to BitwardenSDK imports because those objects will be marked as Sendable at some point in the future, and this enables the newly-Sendable objects to be warning-free.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.56%. Comparing base (2ed93f0) to head (d49c4b2). Report is 6 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #856 +/- ## ======================================= Coverage 88.56% 88.56% ======================================= Files 611 611 Lines 30361 30361 ======================================= Hits 26888 26888 Misses 3473 3473 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 weeks ago

Checkmarx One – Scan Summary & Details – 2c29ca81-a464-469b-9042-bbf934300c1e

bitwarden / ios