[PM-9842] Expired link UI

andrebispo5 commented 3 weeks ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-9842

📔 Objective

Add necessary classes for the expired link UI.

📸 Screenshots

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 95.77465% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.63%. Comparing base (d0dc545) to head (1470573). Report is 3 commits behind head on main.

Files	Patch %	Lines
...leteRegistration/ExpiredLink/ExpiredLinkView.swift	93.75%	2 Missing :warning:
...egistration/ExpiredLink/ExpiredLinkProcessor.swift	90.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #857 +/- ## ========================================== + Coverage 88.61% 88.63% +0.01% ========================================== Files 612 615 +3 Lines 30520 30591 +71 ========================================== + Hits 27046 27114 +68 - Misses 3474 3477 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 weeks ago

Checkmarx One – Scan Summary & Details – a6ed6ae1-90ac-4b59-97b0-338ca0e68852

No New Or Fixed Issues Found

KatherineInCode commented 3 weeks ago

⛏️ Can the name of the PR (/message on the eventual merge commit) be updated with [PM-9842]?

andrebispo5 commented 3 weeks ago

⛏️ Can the name of the PR (/message on the eventual merge commit) be updated with [PM-9842]?

For sure, totally miss that! Thank you :)

bitwarden / ios