bitwarden / ios

Bitwarden mobile app for iOS.
https://bitwarden.com
GNU General Public License v3.0
199 stars 25 forks source link

PM-11253: Don't trigger set master password for non-TDE users on sync #858

Closed matt-livefront closed 2 months ago

matt-livefront commented 2 months ago

🎟ī¸ Tracking

PM-11253

📔 Objective

This fixes a bug where the set master password screen is shown for a key connector user upon sync. This screen should only be shown as part of sync for TDE users who need a password but don't yet have one.

⏰ Reminders before review

đŸĻŽ Reviewer guidelines

github-actions[bot] commented 2 months ago

Logo Checkmarx One – Scan Summary & Details – d2264ad5-fc77-4831-b5ac-ee25067247e6

No New Or Fixed Issues Found

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.61%. Comparing base (d0dc545) to head (224a335). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #858 +/- ## ======================================= Coverage 88.61% 88.61% ======================================= Files 612 612 Lines 30520 30521 +1 ======================================= + Hits 27046 27047 +1 Misses 3474 3474 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.