bitwarden / ios

Bitwarden mobile app for iOS.
https://bitwarden.com
GNU General Public License v3.0
199 stars 25 forks source link

[PM-11133] Expand MainActor annotations #859

Closed KatherineInCode closed 2 months ago

KatherineInCode commented 2 months ago

🎟ī¸ Tracking

https://bitwarden.atlassian.net/browse/PM-11133

📔 Objective

This is part of the iOS 18 / Xcode 16 / Swift 6 effort

This adds @MainActor annotations to a number of protocols to eliminate Swift 6 errors. On the whole, these are delegate protocols between a Processor (which is @MainActor) and a Coordinator (which is @MainActor).

⏰ Reminders before review

đŸĻŽ Reviewer guidelines

github-actions[bot] commented 2 months ago

Logo Checkmarx One – Scan Summary & Details – aea53999-ab62-4c3f-aba6-b7ca2356b528

No New Or Fixed Issues Found

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.61%. Comparing base (d0dc545) to head (cc3f98c). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #859 +/- ## ======================================= Coverage 88.61% 88.61% ======================================= Files 612 612 Lines 30520 30520 ======================================= Hits 27046 27046 Misses 3474 3474 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.