[PM-9842] Show expired link screen

andrebispo5 commented 3 weeks ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-9842

📔 Objective

Show expired link screen when the token validation fails on CompleteRegistration appear.

📸 Screenshots

https://github.com/user-attachments/assets/5cc3773a-3ac0-46c0-9d3a-ba2750162567

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

fedemkr commented 3 weeks ago

@andrebispo5 Is it ok that the user can't press the "X" button? Or I saw this wrongly?

andrebispo5 commented 3 weeks ago

@andrebispo5 Is it ok that the user can't press the "X" button? Or I saw this wrongly?

We can press, I was just hovering the X. It goes to landing.

github-actions[bot] commented 3 weeks ago

Checkmarx One – Scan Summary & Details – 043a36a4-ba86-474a-bb60-3d1fc3c4b79f

No New Or Fixed Issues Found

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.63%. Comparing base (c11be7e) to head (04df2b3). Report is 2 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #862 +/- ## ======================================= Coverage 88.63% 88.63% ======================================= Files 615 615 Lines 30592 30605 +13 ======================================= + Hits 27115 27128 +13 Misses 3477 3477 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bitwarden / ios