PM-11275: Update useKeyConnector flag to keyConnectorEnabled

matt-livefront commented 3 weeks ago

🎟️ Tracking

📔 Objective

Updates the app to use the keyConnectorEnabled flag instead of useKeyConnector on the organization. We were seeing that useKeyConnector would be incorrectly set at times and keyConnectorEnabled is what's used on non-mobile clients.

https://github.com/bitwarden/clients/blob/887d1924a331a292c5425136aac39b14166cf814/libs/common/src/auth/services/key-connector.service.ts#L122

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.63%. Comparing base (0b1afe3) to head (c7b5520). Report is 4 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #863 +/- ## ======================================= Coverage 88.63% 88.63% ======================================= Files 615 615 Lines 30605 30605 ======================================= Hits 27128 27128 Misses 3477 3477 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 weeks ago

Checkmarx One – Scan Summary & Details – 5701be7b-173e-41af-ade2-8a30eb3dfa70

bitwarden / ios