Closed matt-livefront closed 2 months ago
Checkmarx One โ Scan Summary & Details โ d7bb62c6-e905-4750-8739-3b775b71703d
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.63%. Comparing base (
0b1afe3
) to head (58c5823
). Report is 3 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
๐๏ธ Tracking
PM-11297
๐ Objective
After a user removes their master password and migrates to Key Connector, we should set their
hasMasterPassword
flag to false so that their timeout action is updated along with other actions that require the userโs master password (delete account, export vault, etc should use OTP).โฐ Reminders before review
๐ฆฎ Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or โน๏ธ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or ๐ญ (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or โ ๏ธ (:warning:
) for more significant problems or concerns needing attention:seedling:
) or โป๏ธ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes