bitwarden / ios

Bitwarden mobile app for iOS.
https://bitwarden.com
GNU General Public License v3.0
199 stars 25 forks source link

PM-11297: Set hasMasterPassword flag to false after migrating user to Key Connector #866

Closed matt-livefront closed 2 months ago

matt-livefront commented 2 months ago

๐ŸŽŸ๏ธ Tracking

PM-11297

๐Ÿ“” Objective

After a user removes their master password and migrates to Key Connector, we should set their hasMasterPassword flag to false so that their timeout action is updated along with other actions that require the userโ€™s master password (delete account, export vault, etc should use OTP).

โฐ Reminders before review

๐Ÿฆฎ Reviewer guidelines

github-actions[bot] commented 2 months ago

Logo Checkmarx One โ€“ Scan Summary & Details โ€“ d7bb62c6-e905-4750-8739-3b775b71703d

No New Or Fixed Issues Found

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.63%. Comparing base (0b1afe3) to head (58c5823). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #866 +/- ## ======================================= Coverage 88.63% 88.63% ======================================= Files 615 615 Lines 30605 30606 +1 ======================================= + Hits 27128 27129 +1 Misses 3477 3477 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.