PM-10270: Set up unlock later

matt-livefront commented 2 weeks ago

🎟️ Tracking

📔 Objective

Adds support for setting up an unlock method later. Tapping the "Set up later" button will show an alert asking the user to confirm that they want to set up unlock later.

I also added a needsVaultUnlockSetup key in user defaults to determine whether the user has finished setting up unlock. A future PR will set this when the account is created, and then this can be used to determine whether to prompt the user at a future time to set up unlock methods.

📸 Screenshots

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 96.36364% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.66%. Comparing base (85732a9) to head (59e01da). Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
BitwardenShared/UI/Auth/AuthCoordinator.swift	33.33%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #873 +/- ## ======================================= Coverage 88.66% 88.66% ======================================= Files 622 622 Lines 39307 39355 +48 ======================================= + Hits 34850 34896 +46 - Misses 4457 4459 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 weeks ago

Checkmarx One – Scan Summary & Details – 7f6f742e-5fd4-4954-9b65-7bb55eac386c

bitwarden / ios