PM-11430: Fix policy service intermittent test failures

matt-livefront commented 2 months ago

🎟️ Tracking

📔 Objective

This policy service test was added to ensure that simultaneous access to the shared dictionary doesn't crash the app. However, it was also asserting that we only fetch the user's policies from the database once. This was causing occasional test failures. I don't think we can make this assertion though; an actor will ensure the shared state isn't accessed simultaneous from multiple threads, but it isn't going to serialize calls to the policiesForUser method. I don't think we need to guarantee that the policies are only fetched once, so I removed this assertion. I also changed the test to run multiple times to prevent a false positive from causing the test to succeed.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.70%. Comparing base (f5e184f) to head (85861cf). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #877 +/- ## ======================================= Coverage 88.70% 88.70% ======================================= Files 617 617 Lines 30804 30804 ======================================= Hits 27326 27326 Misses 3478 3478 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 months ago

Checkmarx One – Scan Summary & Details – c3b533ab-5978-4b49-9922-e9fb9c2ed2a4

bitwarden / ios