[PM-11420] Fix app taking long time to open on poor connectivity.

fedemkr commented 2 weeks ago

🎟️ Tracking

📔 Objective

Fix issue where the app was taking a lot of time to open appearing to be frozen on the splash screen when having poor connectivity. This was done by moving to background getting the config from server when is not being forced to refresh. So now the AppProcessor and any other place (where the caller doesn't force refresh) are getting the local config immediately and getting the server config on a background task so it's available for the next time is requested.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.71%. Comparing base (f41548e) to head (57b66de). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #878 +/- ## ======================================= Coverage 88.70% 88.71% ======================================= Files 617 617 Lines 30804 30812 +8 ======================================= + Hits 27326 27335 +9 + Misses 3478 3477 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 weeks ago

Checkmarx One – Scan Summary & Details – 5551605a-277e-4b06-b0c1-be7c66b4275e

bitwarden / ios