[BITAU-118] [BITAU-159] Setup New Shared App Group Entitlements and Feature Flag

brant-livefront commented 2 months ago

🎟️ Tracking

BITAU-118 Setup App Group Entitlements
BITAU-159 Add Local Feature Flag for Sync

📔 Objective

This PR:

Adds support for adding the new shared App Group (group.com.bitwarden.bitwarden-authenticator) to the existing entitlements.
Adds a new build property to Common.xcconfig SHARED_GROUP_ORGANIZATION_IDENTIFIER.
- This allows the App Group identifier to be created at build time.
- This allows others to use Local.xcconfig to sign development builds and with their own app group during development.
Adds this group identifier to the Info.plist and a Bundle extension to fetch it.
- This is currently unused but will be needed once we start sharing items via the App Group.
Adds a local feature flag for future use.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.77%. Comparing base (aa6ba21) to head (1be8c9e). Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
...d/Core/Platform/Extensions/Bundle+Extensions.swift	0.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #910 +/- ## ========================================== - Coverage 88.77% 88.77% -0.01% ========================================== Files 617 617 Lines 30898 30909 +11 ========================================== + Hits 27430 27439 +9 - Misses 3468 3470 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 months ago

Checkmarx One – Scan Summary & Details – d89b9d1e-3488-4be3-a786-1cf2292f78dd

bitwarden / ios