[PM-10403] Added SSH key cipher item view

fedemkr commented 1 month ago

🎟️ Tracking

📔 Objective

Add new SSH key cipher item type view and use it in the cipher item view and edition.

Note: This is not the complete feature as it needs the SSH key item to be added to the SDK to completely work. But added the new behavior in all places possible before the SDK update.

📸 Screenshots

View SSH Key cipher item

Edit SSH Key cipher item

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 97.57282% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.10%. Comparing base (5fc811a) to head (ca2164b). Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...red/Core/Vault/Extensions/BitwardenSdk+Vault.swift	33.33%	2 Missing :warning:
...red/UI/Vault/VaultItem/ViewItem/ViewItemView.swift	94.59%	2 Missing :warning:
...t/VaultItem/AddEditItem/AddEditItemProcessor.swift	90.90%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #921 +/- ## ========================================== + Coverage 89.05% 89.10% +0.04% ========================================== Files 654 656 +2 Lines 41057 41261 +204 ========================================== + Hits 36562 36764 +202 - Misses 4495 4497 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

Checkmarx One – Scan Summary & Details – 60d86ec0-5307-4673-86fb-5876e2f36903

bitwarden / ios