[PM-11490] iOS 18 fix broken account switcher

fedemkr commented 1 month ago

🎟️ Tracking

📔 Objective

iOS 18 -> Fix broken account switcher that was being shown behind the toolbar.

Removed scrollOffsetChanged and scrollOffset from the ProfileSwitcherHandler/ProfileSwitcherState/ProfileSwitcherAction as they're no longer necessary as the state is now handled by the ProfileSwitcherView -> Thanks @matt-livefront for this fix/improvement.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

github-actions[bot] commented 1 month ago

Checkmarx One – Scan Summary & Details – 4227faf8-2b58-4735-b9d3-d8a6fb86a5ac

No New Or Fixed Issues Found

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.65%. Comparing base (3aaef4c) to head (331dc85).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #926 +/- ## ========================================== - Coverage 88.67% 88.65% -0.03% ========================================== Files 622 622 Lines 39318 39313 -5 ========================================== - Hits 34866 34853 -13 - Misses 4452 4460 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fedemkr commented 1 month ago

@matt-livefront had to remake the snapshots for the profile switcher because now it doesn't show the blank space behind the toolbar. I think it's ok and I've just overridden the old snapshots with the current behavior. Let me know if you think this could cause an issue somewhere but I can't think of a place where this could go wrong.

matt-livefront commented 1 month ago

@matt-livefront had to remake the snapshots for the profile switcher because now it doesn't show the blank space behind the toolbar. I think it's ok and I've just overridden the old snapshots with the current behavior. Let me know if you think this could cause an issue somewhere but I can't think of a place where this could go wrong.

Ah, I think that's ok. The gap at the top I think is from the safe area, and switching from the VStack to ZStack likely changed the background in the safe area. But since the profile switcher will always display below a navigation bar, I don't think it's an issue.

bitwarden / ios