bitwarden / ios

Bitwarden mobile app for iOS.
https://bitwarden.com
GNU General Public License v3.0
209 stars 26 forks source link

[PM-12579] Add support for compiler flags in CI build workflow #965

Closed vvolkgang closed 1 month ago

vvolkgang commented 1 month ago

🎟ī¸ Tracking

https://bitwarden.atlassian.net/browse/PM-12579

📔 Objective

Add support for compiler flags in our build workflow. This will enable us to create internal builds with compiler flagged features enabled.

⏰ Reminders before review

đŸĻŽ Reviewer guidelines

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.76%. Comparing base (a674339) to head (262048a). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #965 +/- ## ======================================= Coverage 88.76% 88.76% ======================================= Files 638 638 Lines 40082 40082 ======================================= Hits 35580 35580 Misses 4502 4502 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

Logo Checkmarx One – Scan Summary & Details – 7ac3dd14-79c0-4e05-916f-c4f9422c460c

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 146 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...