Closed matt-livefront closed 1 month ago
Checkmarx One â Scan Summary & Details â fbb0b6b7-73f5-4d37-a95f-84ef443032d1
Attention: Patch coverage is 97.79412%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 88.76%. Comparing base (
a674339
) to head (744a96c
). Report is 2 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
đī¸ Tracking
PM-11217
đ Objective
Updates the colors across the app to use the updated colors from the design style guide.
The biggest changes here include:
primaryBitwarden
has been replaced withiconSecondary
,textInteraction
, etc).backgroundSecondary
was used as the background color for most views. This has been updated to bebackgroundPrimary
. AndbackgroundSecondary
is primarily used as the cards and element background color.There's still a few "Legacy" colors in the asset catalog which didn't have a direct mapping to the new style guide and will be removed/replaced in future PRs as components that use these colors are updated (e.g. loading screen, accessory buttons, etc).
đ¸ Screenshots
See snapshots.
â° Reminders before review
đĻŽ Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or âšī¸ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or đ (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or â ī¸ (:warning:
) for more significant problems or concerns needing attention:seedling:
) or âģī¸ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes