Closed vvolkgang closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 89.04%. Comparing base (
bc5a4b3
) to head (9aebadb
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Checkmarx One – Scan Summary & Details – 8901e9e4-745f-4f8a-a07c-76aabca79a44
Severity | Issue | Source File / Package | Checkmarx Insight |
---|---|---|---|
Unpinned Actions Full Length Commit SHA | /build.yml: 87 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... | |
Unpinned Actions Full Length Commit SHA | /build.yml: 144 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
Severity | Issue | Source File / Package |
---|---|---|
Unpinned Actions Full Length Commit SHA | /build.yml: 134 |
Successful test run after dealing with GitHub slow runners yesterday: https://github.com/bitwarden/ios/actions/runs/11134836990
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-10877
📔 Objective
Implement the new version calculation in build.yml. While at it, added a step to output inputs.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or ⚠️ (:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes