bitwarden / ios

Bitwarden mobile app for iOS.
https://bitwarden.com
GNU General Public License v3.0
209 stars 26 forks source link

[PM-10877] Use new version calculation in build workflow #969

Closed vvolkgang closed 1 month ago

vvolkgang commented 1 month ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10877

📔 Objective

Implement the new version calculation in build.yml. While at it, added a step to output inputs.

⏰ Reminders before review

🦮 Reviewer guidelines

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.04%. Comparing base (bc5a4b3) to head (9aebadb).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #969 +/- ## ========================================== - Coverage 89.05% 89.04% -0.01% ========================================== Files 654 654 Lines 41057 41057 ========================================== - Hits 36562 36560 -2 - Misses 4495 4497 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

Logo Checkmarx One – Scan Summary & Details8901e9e4-745f-4f8a-a07c-76aabca79a44

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 87 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 144 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 134
vvolkgang commented 1 month ago

Successful test run after dealing with GitHub slow runners yesterday: https://github.com/bitwarden/ios/actions/runs/11134836990