Closed phil-livefront closed 1 month ago
Checkmarx One â Scan Summary & Details â a909f9e4-f71d-4915-8786-981f8b2fe958
Attention: Patch coverage is 95.81590%
with 10 lines
in your changes missing coverage. Please review.
Project coverage is 88.97%. Comparing base (
d94c5a3
) to head (2aa2947
). Report is 2 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
...toFill/PasswordAutoFill/PasswordAutoFillView.swift | 91.93% | 10 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
đī¸ Tracking
PM-10278 - Draw Turn on Autofill Setup Screen PM-10279 - Implement Turn on Autofill Later Confirmation Dialog PM-10806 - Implement Autofill Help Link
đ Objective
PasswordAutoFillView
so it can be used in the new onboarding flow and also from within the Settings menu. Also kept the legacy version around and is configured based on the feature flagnative-create-account-flow
gifView
using a web view to render the gif. This allows for first party support and seemed simple enough for the one-off gif. If you think we should intro a 3rd party for this, I am happy to update but this felt better imo.fixedSized
helper function to help with testingCompleteRegistrationProcessor
đ¸ Screenshots
Simulating a email verification link click via Reminders app
https://github.com/user-attachments/assets/947b0b86-bc92-4b2d-8273-64aaebd1fa81
â° Reminders before review
đĻŽ Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or âšī¸ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or đ (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or â ī¸ (:warning:
) for more significant problems or concerns needing attention:seedling:
) or âģī¸ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes