bitwarden / ios

Bitwarden mobile app for iOS.
https://bitwarden.com
GNU General Public License v3.0
209 stars 26 forks source link

PM-10278 PM-10279 PM-10806 - Setup autofill screen for new onboarding flow #979

Closed phil-livefront closed 1 month ago

phil-livefront commented 1 month ago

🎟ī¸ Tracking

PM-10278 - Draw Turn on Autofill Setup Screen PM-10279 - Implement Turn on Autofill Later Confirmation Dialog PM-10806 - Implement Autofill Help Link

📔 Objective

📸 Screenshots

Simulating a email verification link click via Reminders app

https://github.com/user-attachments/assets/947b0b86-bc92-4b2d-8273-64aaebd1fa81

⏰ Reminders before review

đŸĻŽ Reviewer guidelines

github-actions[bot] commented 1 month ago

Logo Checkmarx One – Scan Summary & Details – a909f9e4-f71d-4915-8786-981f8b2fe958

No New Or Fixed Issues Found

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 95.81590% with 10 lines in your changes missing coverage. Please review.

Project coverage is 88.97%. Comparing base (d94c5a3) to head (2aa2947). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...toFill/PasswordAutoFill/PasswordAutoFillView.swift 91.93% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #979 +/- ## ========================================== + Coverage 88.91% 88.97% +0.05% ========================================== Files 647 650 +3 Lines 40559 40805 +246 ========================================== + Hits 36064 36306 +242 - Misses 4495 4499 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.