[PM-9907] Change language codes for Chinese and Brazilian Portuguese

Hinton commented 1 month ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12977

📔 Objective

iOS prefers to use the zh-Hans and zh-Hant language codes for traditional / simplified Chinese rather than zh-CN and zh-TW that we previously used. This seems to resolve the issues around the language not working however it also changes how we represent it in the language picker.

We should confirm this language codes are what we desire to use, and how they behave with the system language options.

📸 Screenshots

Before:

After:

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.05%. Comparing base (cbfda94) to head (91e8ee1). Report is 9 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #994 +/- ## ======================================= Coverage 89.05% 89.05% ======================================= Files 654 654 Lines 41057 41057 ======================================= Hits 36562 36562 Misses 4495 4495 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

Checkmarx One – Scan Summary & Details – 514a77ea-f85f-48c0-8dd8-deef388567af

No New Or Fixed Issues Found

KatherineInCode commented 1 month ago

📝 You will need to also update the snapshot tests for this. Particularly, BitwardenShared/UI/Platform/Settings/Settings/Appearance/SelectLanguage/__Snapshots__/SelectLanguageViewTests/test_snapshot_default_large.1.png will need to be regenerated to capture the new names. If you delete that file then run the tests it should generate the new snapshot for you.

Hinton commented 1 month ago

Seems I'm using Xcode 16 which isn't supported by our codebase yet 😓.

jiaobaba1027 commented 2 weeks ago

When can it be repaired?

bitwarden / ios