PM-13104: Remove biometric integrity checks

matt-livefront commented 1 month ago

🎟️ Tracking

📔 Objective

Removes biometric integrity checks. The downside of these checks is that they are unique per-process. So even if biometrics were enabled in the app, opening the autofill extension would require the user to enter their MP or PIN before biometrics would be enabled in that extension. The biometrics auth key already uses biometryCurrentSet which will invalid the keychain item if a finger or face is added for Touch/Face ID. Without these checks, enabling biometrics in the app will cause it to work in any of the extensions immediately vs after the first successful unlock with MP or PIN.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.08%. Comparing base (1549257) to head (bf28a7b). Report is 10 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #995 +/- ## ========================================== - Coverage 89.10% 89.08% -0.03% ========================================== Files 657 657 Lines 41317 41211 -106 ========================================== - Hits 36814 36711 -103 + Misses 4503 4500 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

Checkmarx One – Scan Summary & Details – c1588bed-d1d5-42e3-a87a-dad54adec948

bitwarden / ios