[ps-136] Ignore accented characters in vault search

gbubemismith commented 2 years ago

Type of change

[X] Bug fix
[ ] New feature development
[ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
[ ] Build/deploy pipeline (DevOps)
[ ] Other

Objective

Ignore accented characters in vault searches.

Code changes

common/src/services/search.service.ts: Customised lunr text processing by adding a pipeline function normalizeAccentsPipelineFunction to strip off the accented characters during search. The pipeline function is registered and the added to the pipeline.

Before you submit

[X] I have checked for linting errors (npm run lint) (required)
[ ] I have added unit tests where it makes sense to do so (encouraged but not required)
[ ] This change requires a documentation update (notify the documentation team)
[ ] This change has particular deployment requirements (notify the DevOps team)

Hinton commented 2 years ago

We could look into extending Lunr to be unicode safe per https://github.com/olivernn/lunr.js/issues/269. The last gist is compatible with 2 but not something I've used.

gbubemismith commented 2 years ago

We could look into extending Lunr to be unicode safe per olivernn/lunr.js#269. The last gist is compatible with 2 but not something I've used.

I would look into this right away

gbubemismith commented 2 years ago

We could look into extending Lunr to be unicode safe per olivernn/lunr.js#269. The last gist is compatible with 2 but not something I've used.

@Hinton I was able to customise lunr and added a pipeline function to handle accented characters. This is a cleaner approach as we follow DRY principle.

bitwarden / jslib