[PS-136] stripped off accented characters from search field for browser client - Githubissues

bitwarden / jslib

Common code referenced across Bitwarden JavaScript projects.

https://bitwarden.com

GNU General Public License v3.0

134 stars 138 forks source link

[PS-136] stripped off accented characters from search field for browser client #812

Closed gbubemismith closed 2 years ago

gbubemismith commented 2 years ago

Type of change

[X] Bug fix
[ ] New feature development
[ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
[ ] Build/deploy pipeline (DevOps)
[ ] Other

Objective

Replicate same functionality of being able to search for texts with accented characters using normal texts.

Code changes

angular/src/components/ciphers.component.ts: Added normalize("NFD").replace(/[\u0300-\u036f]/g, "") to the searchText variable to strip off accent from a character.
This PR is related to https://github.com/bitwarden/web/pull/1690 and https://github.com/bitwarden/jslib/pull/804

Before you submit

[X] I have checked for linting errors (npm run lint) (required)
[ ] I have added unit tests where it makes sense to do so (encouraged but not required)
[ ] This change requires a documentation update (notify the documentation team)
[ ] This change has particular deployment requirements (notify the DevOps team)

gbubemismith commented 2 years ago

Is there any reason why we're not normalizing the search string in SearchService itself? Ideally this should be handled by the service, so that you don't have to repeat the normalization logic everywhere that it's called from.

Also, don't forget to handle searching Sends as well. If you do it in SearchService, then you could have a single private method, normalizeSearchQuery, which is called from both SearchCiphers and SearchSends.

This has been added.