Closed gbubemismith closed 2 years ago
Is there any reason why we're not normalizing the search string in
SearchService
itself? Ideally this should be handled by the service, so that you don't have to repeat the normalization logic everywhere that it's called from.Also, don't forget to handle searching Sends as well. If you do it in
SearchService
, then you could have a single private method,normalizeSearchQuery
, which is called from bothSearchCiphers
andSearchSends
.
This has been added.
Type of change
Objective
Code changes
angular/src/components/ciphers.component.ts: Added
normalize("NFD").replace(/[\u0300-\u036f]/g, "")
to thesearchText
variable to strip off accent from a character.This PR is related to https://github.com/bitwarden/web/pull/1690 and https://github.com/bitwarden/jslib/pull/804
Before you submit
npm run lint
) (required)