[EC-237] Fix lockGuard redirect - Githubissues

bitwarden / jslib

Common code referenced across Bitwarden JavaScript projects.

https://bitwarden.com

GNU General Public License v3.0

134 stars 138 forks source link

[EC-237] Fix lockGuard redirect #819

Closed eliykat closed 2 years ago

eliykat commented 2 years ago

Type of change

[x] Bug fix
[ ] New feature development
[ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
[ ] Build/deploy pipeline (DevOps)
[ ] Other

Objective

LockGuard wasn't redirecting properly because it had accidentally nested an array in an array for the redirectUrl.

will be picked to rc

Code changes

Remove array nesting

Before you submit

[x] I have checked for linting errors (npm run lint) (required)
[ ] I have added unit tests where it makes sense to do so (encouraged but not required)
[ ] This change requires a documentation update (notify the documentation team)
[ ] This change has particular deployment requirements (notify the DevOps team)

eliykat commented 2 years ago

@djsmith85 only took me like an hour of debugging to find 🙃