[fix] Generator settings not persisting across web sessions - Githubissues

bitwarden / jslib

Common code referenced across Bitwarden JavaScript projects.

https://bitwarden.com

GNU General Public License v3.0

134 stars 138 forks source link

[fix] Generator settings not persisting across web sessions #824

Closed addisonbeck closed 2 years ago

addisonbeck commented 2 years ago

https://bitwarden.atlassian.net/browse/SG-358

Type of change

[x] Bug fix
[ ] New feature development
[ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
[ ] Build/deploy pipeline (DevOps)
[ ] Other

Objective

Username and password generator settings don't use local storage for web, so they don't persist across sessions.

This is needed for a hotfix for web, and thus will need to be merged here and recreated in clients

Code changes

Use the correct storage options for generator settings so they are persistent across web sessions

Before you submit

[x] I have checked for linting errors (npm run lint) (required)
[ ] I have added unit tests where it makes sense to do so (encouraged but not required)
[ ] This change requires a documentation update (notify the documentation team)
[ ] This change has particular deployment requirements (notify the DevOps team)