search

bitwarden / mobile

Retired Bitwarden mobile app for iOS and Android (MAUI/Xamarin).
https://bitwarden.com
GNU General Public License v3.0
99 stars 12 forks source link

Bitwarden not recognising Edge Canary browser on Android #1394

Open CErWXZGhpfdpTx1GhuYxZPPng94T7fhUaItEjlo opened 3 years ago

CErWXZGhpfdpTx1GhuYxZPPng94T7fhUaItEjlo commented 3 years ago

Describe the Bug

Bitwarden doesn't recognise the new Edge Canary browser on Android as a web browser.

Steps To Reproduce

  1. Download Edge Canary from Play Store
  2. Open any website with a password field
  3. Click Auto-fill with Bitwarden

Expected Result

Bitwarden searches for the web site you are viewing and displays the result for that web site

Actual Result

Bitwarden searches for com.microsoft.emmx.canary or something similar, you then have to manually search for the web site

Screenshots or Videos

Environment

Additional Context

1AqK1kLtAzkWAkk9i0YkQXo6KXwAx9AmzgFhLtV commented 3 years ago

Hello @danmac,  

Please see PR https://github.com/bitwarden/mobile/pull/1370:

add package for support Microsoft Edge Beta/Canary/Dev version.

(note: the Beta version doesn't exist at the moment but has already been added in advance.)  

:arrow_right: This PR was recently merged, so it will be available in the next release. :thumbsup:  

See also the remark that @djsmith85 made here: :wink:

@fabis94 Glad I could help. Could you please close the issue. It saves the Devs from going through solved issues.

Thanks. :thumbsup:

431QIFp6BbmFcu1weKCtoctHAMifaTO0F3TGYrS commented 3 years ago

Hello @contribucious , I tested with newest Bitwarden (2.10.0) and it still doesn't work for Edge canary. Could you please take a look again if the PR itself really works or some other code changes are needed as well? :)

Sx4b42eIQCROUHjRQpLb79uCUKBCmcVzRvbpk2s commented 3 years ago

Hello @contribucious , I tested with newest Bitwarden (2.10.0) and it still doesn't work for Edge canary. Could you please take a look again if the PR itself really works or some other code changes are needed as well? :)

Can confirm it's still broken

1AqK1kLtAzkWAkk9i0YkQXo6KXwAx9AmzgFhLtV commented 3 years ago

@xiaoyuin (@wight554) Hello. Really sorry, could not answer before (very busy at the moment).

:arrow_right: Yes, the PR of @laymanZ is correct regarding the addition of browser support (I mean … the package name is com.microsoft.emmx.canary and the "resource-id" is indeed equal to url_bar as visible on the screenshot n°1 below). So, this line for ex. is indeed correct.

For my part, enabling "Auto-fill Service" (i.e. Autofill Framework) + "Use Accessibility" (i.e. Accessibility Service) + "Use Draw-Over" in Bitwarden settings, I have no problem to use it, see screenshots n°2 and n°3 (additional note: github.com was successfully detected).

BUT … only the accessibility service seems to be used (see screenshot n°4), unlike the latest stable version of Chrome which is the 91.0.4472.88 (see screenshot n°5).

:arrow_right_hook: The situation should be further analyzed then (to see if the problem lies with Bitwarden or Edge Canary, etc.). See with the team therefore (@mportune-bw, @cscharf, …), specifying the precise type of your problem (i.e. what you mean exactly by "doesn't work"), whether you use Autofill Framework, Accessibility Service or both, if the "Draw-Over" permission has been given (in Bitwarden settings > "Auto-fill Services"), your device info (model, …) and version of Android / Edge Canary / Bitwarden, etc. (open another issue if necessary). Same remark for you @wight554. :wink:  

My context

* Tested both with Autofill Framework + Accessibility Service and with Accessibility Service only. Regarding the use of Autofill Framework alone, it is "normal" that this doesn't work, this is also the case with Chrome Stable by the way (known situation).  

Screenshot(s)

Screenshot n°1

Microsoft_Edge_Canary Edge Canary 93.0.910.0.

CErWXZGhpfdpTx1GhuYxZPPng94T7fhUaItEjlo commented 3 years ago

Thanks for the extra work on this, I can confirm that mine shows the same behaviour as your screenshots. Let me know if you need someone to test anything.

Sx4b42eIQCROUHjRQpLb79uCUKBCmcVzRvbpk2s commented 3 years ago

in my case I can't see keyboard autofill like in other browsers, accessibility overlay works just fine

431QIFp6BbmFcu1weKCtoctHAMifaTO0F3TGYrS commented 3 years ago

Appreciate for the investigation and detailed reply. By doesn't work I meant neither accessibility service or draw-over was enabled. But it doesn't matter, we have also done some research and now I'm quite sure that you have done everything right. The problem is on the Edge side. Thank you again for the help and all the efforts you have made. :)

1AqK1kLtAzkWAkk9i0YkQXo6KXwAx9AmzgFhLtV commented 3 years ago

@xiaoyuin My pleasure! :thumbsup: