search

bitwarden / mobile

Retired Bitwarden mobile app for iOS and Android (MAUI/Xamarin).
https://bitwarden.com
GNU General Public License v3.0
126 stars 19 forks source link

Improve the search feature #311

Closed lucIQBGbQactoDrplZ7SGxBL5vVQB4sciSOEt8a closed 5 years ago

lucIQBGbQactoDrplZ7SGxBL5vVQB4sciSOEt8a commented 6 years ago

The search screen usually take 10s to show. Is it normal? I think we should ignore spaces at the end of the search word. For example when I'm searching for Paypal password I usually type Pay and my keyboard suggest Paypal so when I accept that suggestion the keyboard add a space at the end and then the app show no results.

pPmnBRRYhIemiuiy3VBYULJIzQyZaEvWMbCPH1P commented 6 years ago

No, that is not normal. Its nearly instant on my test device. What type of device are you using? How large is your vault?

lucIQBGbQactoDrplZ7SGxBL5vVQB4sciSOEt8a commented 6 years ago

I am using a Zuk Z2 Plus phone with an oreo custom rom. My vault is about a thousand entries.

4JYbyTwRGLXNYyuRqZwRvkKcFwzzhst76YdWqpd commented 6 years ago

I’m on an iPhone 6 and around 900 entries and search usually takes 4-5 seconds to load. It has gotten better in recent updates but still not as good as 1Password or even Enpass. Love Bitwarden in general, so I would love to keep supporting it!

nEyZDvWeUOoGHZUfmltYHPz6CpQL2Ro99RvhV4O commented 6 years ago

I have a Samsung Galaxy S8 with around 900 sites. Clicking search regularly takes 10s or more for me. I love the app otherwise but this really breaks up the workflow

7pPmev5Hf9y5VYi3UbDjohQi5BCWKmwGPMtPxVc commented 6 years ago

It is far worse on my phone, on the order of 1 minute before the Search screen is loaded and ready to use. I have 1662 items (yikes). I have a 2 year old, sort of low-end phone (BLU HD R1) but it is plenty fast for other heavy apps like Slack, Carcassonne, OneNote, etc.

I haven't looked at the code yet to see, but does it build a ListView with all items, rather than lazy-loading them? I can't imagine sorting the items is slow, so I assume it is a UI-rendering perf problem with all those items.

Also, why show password items at all on the search screen? Well, I understand some people might want to scroll through them. I would prefer not, if that's causing the huge delay.

My specific request would be, if the user has > 300 items (or 500, whatever), do not show the items list below the search box and instead show a button to "Show all items".

But also, I request looking at why the full items list is so slow when number of items is large. But please stop showing them all in the meantime! :)

tfcQouJBs5fjVasNCUMtQvP7r6bT3jdn0VMR7M0 commented 5 years ago

super slow here as well - 2,145 items

search list should not load the list and then search.

it ought to search then show matches.

pPmnBRRYhIemiuiy3VBYULJIzQyZaEvWMbCPH1P commented 5 years ago

Can you test v2.0 beta on play store and see if this has been improved?

tfcQouJBs5fjVasNCUMtQvP7r6bT3jdn0VMR7M0 commented 5 years ago

Excellent, only have to wait ages for that first load. Doing a search is near instant now. Top job