bitwarden / mobile

Retired Bitwarden mobile app for iOS and Android (MAUI/Xamarin).
https://bitwarden.com
GNU General Public License v3.0
146 stars 23 forks source link

iOS app crashes while attempting to edit logins and Secure notes #3146

Open aXkHEpsCZWAiL7Q2155M9kRTn5MyTdF6qjr3iQ2 opened 7 months ago

aXkHEpsCZWAiL7Q2155M9kRTn5MyTdF6qjr3iQ2 commented 7 months ago

Steps To Reproduce

  1. Go to 'Logins or Secure notes'
  2. Click on 'Edit'

Expected Result

App should not crash.

Actual Result

App crashes.

Screenshots or Videos

No response

Additional Context

This happens when logins with larger text entries in the notes section is picked for editing or Secure notes with longer entries are picked for editing.

Operating System

iOS

Operating System Version

17.4.1

Device

iPhone 13

Build Version

2024.3.3(7191)

Beta

yvCiXpfMZsTgTWvhIE0LmrgAcVE7155rfTbA7nd commented 7 months ago

Hi there,

I attempted to reproduce your issue and was unable to do so. Could you please try uninstalling Bitwarden, restarting your device, and reinstalling the Bitwarden application?

We use GitHub issues as a place to track bugs and other development-related issues. If your issue persists, please write us back using our “Contact Support” form located on our Help Center (https://bitwarden.com/help/).

You can include a link to this issue in the message content.

Alternatively, you can also search for an answer in our help documentation or get help from other Bitwarden users on our community forums (https://community.bitwarden.com/c/support/).

The issue here will be closed.

Thanks!

aXkHEpsCZWAiL7Q2155M9kRTn5MyTdF6qjr3iQ2 commented 7 months ago

Noticed something else - issue cannot be reproduced by freshly creating an entry with a random long text. You either need to clone an existing entry that crashes or create a new entry by copy pasting the content of notes section of it.

SergeantConfused commented 6 months ago

Hi @Kabyss,

Thank you for following up on this. Going by your last comment, it sounds like there could be something specific in that text that is causing Bitwarden to close unexpectedly; To be clear, I cannot reproduce this with a large Secure Note that was created in the Web App and then accessed in Edit mode on the iOS client.

Could you please create a support ticket so we'd be able to collect more information from you directly? I'm hoping that you see a pattern in the Secure Notes that are causing this; Please remember to include a link to this GitHub report in your message.

Thank you in advance,

aXkHEpsCZWAiL7Q2155M9kRTn5MyTdF6qjr3iQ2 commented 6 months ago

From the Reddit thread, it seems like the character “-“ is the culprit. Can confirm that my issue is also same.

https://www.reddit.com/r/Bitwarden/s/WFDetk3vRD

cbbit commented 6 months ago

Hi @Kabyss

I was able to reproduce this issue, and I have flagged this to our engineering team.

If you wish to add any further information/screenshots/recordings etc., please feel free to do so at any time - our engineering team will be happy to review these.

Thanks once again!

pFAuRlhdkDiIsvTCrA4AtYBzdkzcB5VKpsTa4Dj commented 5 months ago

Same issue. Not sure that - is the problem as I have not that character and yet still crash.

Pls fix.

aXkHEpsCZWAiL7Q2155M9kRTn5MyTdF6qjr3iQ2 commented 5 months ago

@Fealthas It is possible that “-“ isn’t the only character that triggers it. I would suggest editing the entry and doing a bit of trial and error to see if you can narrow it down to a particular one.

pFAuRlhdkDiIsvTCrA4AtYBzdkzcB5VKpsTa4Dj commented 5 months ago

I also have & @ And . Otherwise just normal ascii text. Can't edit because it crashes hahaha.

aXkHEpsCZWAiL7Q2155M9kRTn5MyTdF6qjr3iQ2 commented 5 months ago

For me, editing from the browser extension or desktop app didn’t result in a crash. I tried with & @ and . but no crash.

5raj3uD9QkcNIUNwA8IASakeukhmxz3InpuszQT commented 5 months ago

Okay, I finally logged into github as I have had this iOS app crash for some time (months). I noticed one user above eliminated the "-" from their file. While I have a bias to using "-" or "--" for certain things in the vault, I went ahead and eliminated them to see if it worked....and it did. I can now edit and save. Hard to believe the dash was the culprit, but hey, eliminating it allows me to edit on the app again.

cansandjars commented 3 months ago

Will this be addressed at some point? Many have reproduced. This bug has been bugging me for years and I've also confirmed that consecutive dashes (--) in any notes field in any type of record will crash iOS app upon tapping "Edit".

Greenderella commented 2 months ago

Hi there,

Please try reproducing the issue with the beta version of the native app. The beta program can be joined, and the app downloaded following these instructions: https://community.bitwarden.com/t/about-the-beta-program/39185

Given the recent updates to the beta builds, it would be beneficial to verify if the problem persists with the latest version.

Thanks for your assistance, and I eagerly await your feedback!