bitwarden / mobile

Retired Bitwarden mobile app for iOS and Android (MAUI/Xamarin).
https://bitwarden.com
GNU General Public License v3.0
24 stars 3 forks source link

Simple Login forward aliases should not be random #3189

Open kzRjaADQQPdG4xNzYARZdJwycITusYynYJps5Kn opened 2 months ago

kzRjaADQQPdG4xNzYARZdJwycITusYynYJps5Kn commented 2 months ago

Steps To Reproduce

  1. Create a new entry in Bitwarden
  2. Go into username generator
  3. Select forwarded email alias
  4. Chose SimpleLogin provider (add your API key)
  5. Generate the alias

Expected Result

I expect the alias to contain the domain name of the website for which I created the alias (this is how behaves the web browser extension).

For instance, let's assume I follow the steps above from the web extension and create an entry from Amazon website. Here is the kind of result I can get: image You can see "amazon" in the email adress.

I would expect the same behavior on mobile app.

Actual Result

If I do this from the Android app, I get a complete random alias, like spider_shocking.abcde@simplelogin.com. This makes it harder to track which adress is linked with which website.

Screenshots or Videos

No response

Additional Context

It seems in src/Core/Services/EmailForwarders/SimpleLoginForwarder.cs, you use the Simple Login API to generate a random alias.

You could instead use this POST method and pass the domain name to the alias_prefix parameter: https://github.com/simple-login/app/blob/master/docs/api.md#post-apiv3aliascustomnew

Thanks in advance, Cheers,

Operating System

Android

Operating System Version

No response

Device

No response

Build Version

2024.4.0 (10172)

Beta

cbbit commented 2 months ago

Hi there,

Thank you for your report!

I was able to reproduce this issue, and I have flagged this to our engineering team.

If you wish to add any further information/screenshots/recordings etc., please feel free to do so at any time - our engineering team will be happy to review these.

Thanks once again!