[PM-9483] Fix added Attachment from the Edit Cipher Screen on mobile apps can't be retrieved - Githubissues

bitwarden / mobile

Retired Bitwarden mobile app for iOS and Android (MAUI/Xamarin).

https://bitwarden.com

GNU General Public License v3.0

152 stars 24 forks source link

[PM-9483] Fix added Attachment from the Edit Cipher Screen on mobile apps can't be retrieved #3344

Closed LRNcardozoWDF closed 4 months ago

LRNcardozoWDF commented 4 months ago

Type of change

[X] Bug fix
[ ] New feature development
[ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
[ ] Build/deploy pipeline (DevOps)
[ ] Other

Objective

Ensure attachments that are added on edit cipher screen can be retrieved.

Code changes

src/Core/Services/CipherService.cs: Although attachments added on edit cipher screen are updated on server, that state isn't applied to the cipher in memory. This ensures that the current cipher has the updated attachments.

Screenshots

Before you submit

Please check for formatting errors (dotnet format --verify-no-changes) (required)
Please add unit tests where it makes sense to do so (encouraged but not required)
If this change requires a documentation update - notify the documentation team
If this change has particular deployment requirements - notify the DevOps team